Add new parameters to snapshot restore to rename the restored aliases…

[mispencer]

Description

Add new parameters to snapshot restore to rename the restored aliases similar to how you can currently rename the restored indexes.

Related Issues

Resolves #15632

Check List

• [x] Functionality includes testing.
• [x] API changes companion pull request created, if applicable. - PR 615
• [x] Public documentation issue/PR created, if applicable. - PR 8544

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions[bot]]

:x: Gradle check result for 8e511d662412abd32cde8547dddd607f54c02c0b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:x: Gradle check result for 019c62f624ccdb42f0e70d58c6b3effc6e42e808: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:white_check_mark: Gradle check result for 2a48d9d1118bc6a45d4dba7f0c69a2f4662e2d59: SUCCESS

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 68.08511% with 15 lines in your changes missing coverage. Please review.

Project coverage is 72.12%. Comparing base (ca40ba4) to head (dbc3e5b). Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...ster/snapshots/restore/RestoreSnapshotRequest.java	64.28%	2 Missing and 8 partials :warning:
...apshots/restore/RestoreSnapshotRequestBuilder.java	0.00%	4 Missing :warning:
.../java/org/opensearch/snapshots/RestoreService.java	93.33%	0 Missing and 1 partial :warning:

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #16292      +/-   ##
============================================
+ Coverage     72.09%   72.12%   +0.03%     
- Complexity    65013    65067      +54     
============================================
  Files          5313     5313              
  Lines        303315   303356      +41     
  Branches      43888    43900      +12     
============================================
+ Hits         218661   218809     +148     
+ Misses        66721    66658      -63     
+ Partials      17933    17889      -44     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[github-actions[bot]]

:white_check_mark: Gradle check result for 6c1f97d4b2f66e43c095717411de258888689730: SUCCESS

[github-actions[bot]]

:x: Gradle check result for 1f29b96594ea46e12977c7163f99b1cb9aa83a1a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:x: Gradle check result for 44c2dd915ee9941a5a0bee615e3d8db58bed88e6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:x: Gradle check result for 22c083a9591ba844ca9c7b38f54ba387d3b4fe7d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:x: Gradle check result for ec420da7f52aa64327b73d9e174c2f1a09a301d3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:white_check_mark: Gradle check result for 1a74eba336dd5c52ef375ef0dfd174a2a78706c8: SUCCESS

[github-actions[bot]]

:white_check_mark: Gradle check result for add9dae332fd676d5314223928d068f28435b183: SUCCESS

[dblock]

Please don't forget https://github.com/opensearch-project/opensearch-api-specification. See https://github.com/opensearch-project/opensearch-api-specification/pull/611 for recent changes in that space.

[mispencer]

I intended to wait until this PR has been reviewed, but ok. I have created related PRs in the documentation and spec projects.

[mispencer]

I assume the Changeling Verifier check fails is not meaningful. I also assume that the codecov/patch failure is not fatal.

[dbwiddis]

I assume the Changeling Verifier check fails is not meaningful. I also assume that the codecov/patch failure is not fatal.

You can see which checks are required over on the right. A changelog entry is required, while the coverage is advisory -- mostly a prompt for us to look more closely at whether tests were missed.

If you look at the change log failure, you can see that there's no backport tag on this PR, but the Change Log entry is listed for 2.x. So if this is intended to be backported (as the change log suggests) we need to add the backport tag.

[github-actions[bot]]

:grey_exclamation: Gradle check result for af76dd62d89d7df0281747aeb199b522c06c1e10: UNSTABLE

• TEST FAILURES:

      3 org.opensearch.cluster.MinimumClusterManagerNodesIT.classMethod
      2 org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testContainerCreationAndDeletion

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[github-actions[bot]]

:x: Gradle check result for a41cff34f0b96e4bb7d3de0f40b55e863631bbb0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:x: Gradle check result for 43edd83bd465848211118dbd1244d3e54dddecf3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[dbwiddis]

@yigithub @jed326 @neetikasinghal Could one of you give this PR a once over as well?

[github-actions[bot]]

:x: Gradle check result for 4e9d1b742928d09211a705fb5986dfe89b1633c8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:x: Gradle check result for 06bd62d4a384a5cef189db77612211a898a29778: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:white_check_mark: Gradle check result for 360375c725931d0a08b22ab3ad2e213b6777ca3a: SUCCESS

[github-actions[bot]]

:white_check_mark: Gradle check result for da78c1f33fd3deecc938c05007ab012bdc930b62: SUCCESS

[jed326]

Thanks @mispencer! Left one comment. The changes look good to me but I haven't been very hands on on Snapshots lately, would be great to get someone more involved like @sachinpkale or @ashking94 to give it another review.

[mispencer]

@dbwiddis - are your conversations resolved?

[github-actions[bot]]

:white_check_mark: Gradle check result for 4c34e172678649a12bf191d04cf38db27205a0cf: SUCCESS

[dbwiddis]

@dbwiddis - are your conversations resolved?

Yes but per the previous comment hoping @ashking94 or @sachinpkale can review. I'll merge tomorrow otherwise.

[github-actions[bot]]

:x: Gradle check result for 50e07d324a1a865c845e70a9632dfb14f5cdd6d0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions[bot]]

:white_check_mark: Gradle check result for dbc3e5bd78ecf73da75231d21e1772b8304df5aa: SUCCESS

[opensearch-trigger-bot[bot]]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-16292-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9489a21a7466dbc6320b4b53c828ff3bfbce2b22
# Push it to GitHub
git push --set-upstream origin backport/backport-16292-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-16292-to-2.x.