Derek
Derek
Other than a few comments, LGTM. Once you make the suggested changes, could you rebase everything to a single commit?
To me, it looks like its related to localization. Usually when you first localize robot, its particle cloud is pretty spread out the estimated robot position jumps around at bit...
> Please rebase your PR to incorporate the changes from #377. Done
@gbiggs It looks like some/all the of integration tests were failing because the rosmaster wasn't coming up?
> The `convert_all_in_one_stream` function name is no better than the previous function names. You are relying on the types of the function arguments for the correct function to be called....
@gbiggs I made the name change, but couldn't make the function private, because a whole bunch of other Factory types need to use it.
@gbiggs is it possible to trigger a full test run?
I was able to reproduce this build failure by compiling with optimization turned on ``` colcon build --packages-select ros1_bridge --cmake-force-configure --cmake-args -DCMAKE_BUILD_TYPE=RelWithDebInfo ``` It looks like the RelWithDebInfo build causes...
@gbiggs Looks like stuff compiled, but most/all live tests are failing because they can't access the rosmaster ? ``` 11: [ros1_talker_ros2_listener_across_dynamic_bridge__dynamic_bridge-2] [ERROR] [1669537320.951368727]: [registerPublisher] Failed to contact master at [localhost:11311]....