Dylan Anthony

Results 203 comments of Dylan Anthony

Hmm, I'm still seeing the same error 🤔 I could have done something wrong though. I installed the new version like `cargo install --git https://github.com/sagiegurari/cargo-make --branch=0.35.16` (I've never used that...

I'm pretty sure this project is available via `cargo-quickinstall` now—though I've been using [`cargo-binstall`](https://github.com/ryankurte/cargo-binstall) to get at it. I'm not sure about resolution priority, but you could support the `cargo-binstall`...

The `include_router` function in `FastAPI` is expecting an `APIRouter`, and will only register `Route`s that are included on that `APIRouter`. A `StaticFiles` is a sub-application, not a `Route`. I believe...

@tiangolo we probably need your opinion here on design. Would it be appropriate for `include_router` to also mount any sub-applications that have been mounted to that`APIRouter` (with appropriate prefix)? Or...

Firstly, nice work! As you said, this is a fully working solution to using MongoDB with FastAPI that I'm sure will benefit people going forward. I would highly recommend that...

Kind of a funny syntax, at least not one I’ve seen before. Appending would just be for passing through options right? This is a syntax I’ve seen a few places...

I'm a bit confused, are you saying you don't like providing positional arguments after `--` because it could be a typo? Like someone typed `dephell venv run -- env=pytest` but...

To clarify, my suggestion is that everything after `--` be passed through to the inner command. So `dephell venv run --env=pytest -- test.py -x --tb=short` would basically be running `pytest...

I think we're still not thinking along the same lines on this one, so let me type out a bit of an example to try and clarify further. Let's say...