Daniel Brooks

Results 248 comments of Daniel Brooks

Looks like the Clippy test is running autogen, configure, etc first. Is that necessary, or can it be skipped?

I see that `fget_internal_border_width` is inside an `#ifdef HAVE_WINDOW_SYSTEM`; perhaps the call to it should be similarly ifdef'd?

I think it's fine for it to be an error, as long as it is consistent between normal and CI builds. To fix the error, I'm pretty sure we can...

> `Attempt to write memory outside diversion session and CHECK_LISP_OBJECT_TYPE not set errors.` I've run into this before. In order to preserve the correct replay behavior, rr must prevent the...

I hear ya. Perhaps there should be something along the lines of [{"cmd": "method", "elem": "#id_date", fun: "val", "val": "2014-04-08"}], but that's not for me to say. In any case,...

Only a subset of the systems that MAME supports are actually available on archive.org. Sometimes this is a technical limitation (some systems don’t run well enough or fast enough in...

I’ve been having the same problem with X4: Foundations and a few other games. Toggling the “Force the use of a specific Steam Play compatibility tool” checkbox in the game’s...

So one thing that I didn’t mention is that there is also the `SUNDEATH` effect, which harms creatures in direct sunlight. It calls `game::is_in_sunlight`, which really just checks to see...

The SUNDEATH effect checks the solar irradiance (in units of W/m²) rather than the ambient light level (if this is in a consistent unit it is unknown to me). It...

I wasn’t going to bother fixing them because you said that you didn’t want this patch. I did #70799 instead. It fixes the bug in how much they regenerate without...