Dawid Wysakowicz

Results 24 comments of Dawid Wysakowicz

I think that's a fair approach. I agree very few users implement state backends and if they do they are knowledgeable enough to easily migrate their code. Moreover we changed...

https://github.com/apache/flink/pull/23411#pullrequestreview-1770150649 It took me a while to understand that myself, but I think it's actually ok to depend on the `Object#equals/hashcode` in `AggregateFunctions` @snuyanzin what you said is correct for...

Sorry, it takes such a long time from my side. I had a vacation in the meantime. I'll try to check it Monday. Nevertheless if you're comfortable with the PR...

Thanks for the update @Jiabao-Sun The implementation looks good now. I want to go through the tests again, but I need a bit more time. I hope this is fine,...

CI seems broken by https://github.com/apache/flink/pull/24022#issuecomment-1888811191

Sure, I will during my working days. Also to be clear it's definitely too late now for it to make it to 1.17. It's in a too important area to...

Hey @masteryhx, do you plan to work on that for 1.18?

Thank you for the PR @jnh5y I left some comments.