David Glick

Results 452 comments of David Glick

This happened because you had the bad luck to pick a package name that collided with one of the core Plone packages (plone.volto). I recommend picking a name that reflects...

Yeah, the constraints file is more than just Plone packages (also it includes Plone's dependencies) but that's fine for this purpose; we don't want someone using the cookiecutter to use...

One note -- pip does some normalization so `plone.volto` and `plone-volto` are considered the same package.

@stevepiercy There should be a prompt to update the snapshots when the tests are run as documented here: https://6.docs.plone.org/volto/contributing/testing.html#run-jest-tests-on-volto-core

@stevepiercy @jensens I think we basically agree on most of how you are thinking about cookiecutter-volto, and I withdraw my objection to adding this documentation. However, I have one request...

@sneridagh It's not immediately obvious to me why the storybook build in the generator test is failing

@stevepiercy At present, we expect development of volto itself to be done using pnpm, but we still expect yarn for projects built by the volto generator, which is what that...

@stevepiercy Well, I assume so, since I updated it within the past hour and only merged one other unrelated PR since then.

@stevepiercy No, it doesn't. That's why I asked @sneridagh about it above.

@sneridagh doesn't that require a babel configuration at the root of the addon repo?