plone
Add hindi translation in Volto
Deploy Preview for plone-components canceled.
| Name | Link |
|---|---|
| Latest commit | cc4595a2194fd68789db678eeb63288de67d4d1a |
| Latest deploy log | https://app.netlify.com/sites/plone-components/deploys/664b48ab86c14f0008a8ec93 |
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy Preview for volto failed. Why did it fail? →
| Name | Link |
|---|---|
| Latest commit | db23888c25377bc42973900ea9bac3d6c0373563 |
| Latest deploy log | https://app.netlify.com/sites/volto/deploys/66466ee042b3160008bd268e |
@sneridagh @stevepiercy we should probably list the supported languages somewhere in documentation
@sneridagh @stevepiercy we should probably list the supported languages somewhere in documentation
Agreed, but what would it look like? Would it be just a list of supported languages, links to the repos where you can see which languages are supported, or a combination of both?
Classic UI and Volto have different supported languages, 69 versus 14 plus 1 from this PR, so we need to make that distinction.
I'd suggest adding content to Internationalization and Localization in the main documentation.
We should also add a step to each process for adding a new language, where the contributor adds it to the listing in the main documentation, too.
@stevepiercy @iRohitSingh Will work on the Hindi translation in Plone core during the sprint.
@stevepiercy @iRohitSingh Will work on the Hindi translation in Plone core during the sprint.
That would be awesome. We have documentation for how to add languages for Plone Classic UI, but I am not certain if it is correct. Please feel free to submit PRs for that as well.
@stevepiercy @iRohitSingh Will work on the Hindi translation in Plone core during the sprint.
That would be awesome. We have documentation for how to add languages for Plone Classic UI, but I am not certain if it is correct. Please feel free to submit PRs for that as well.
That docs are OK. I reviewed them some time ago and they are still OK.
I am waiting for the final approval from Weblate to have a Free plan there and include that documentation too.
Anyway, Weblate can be used also to contribute Classic UI translation right now. Not for Volto (there are still some issues).
@iFlameing we need to update too: https://github.com/plone/volto/blob/main/packages/volto/src/constants/Languages.js#L7
Thanks!
@iFlameing we need to update too: https://github.com/plone/volto/blob/main/packages/volto/src/constants/Languages.js#L7
And that step needs to be added to the overview in https://6.docs.plone.org/volto/development/i18n.html
I also noticed that https://6.docs.plone.org/volto/development/i18n.html#broad-overview mentions .json files, and see that they are excluded from the repo in .gitignore. It's not clear what a developer should do with them or if there is some automation that takes care of it for the developer. Can someone enlighten me so I can update the docs accordingly?
@iFlameing we need to update too: https://github.com/plone/volto/blob/main/packages/volto/src/constants/Languages.js#L7
And that step needs to be added to the overview in https://6.docs.plone.org/volto/development/i18n.html
Done in https://github.com/plone/volto/pull/6016/commits/f76797982cf36f475484b69c0565492750e52149. I also cleaned up grammar and syntax in the docs.
@sneridagh @stevepiercy we should probably list the supported languages somewhere in documentation
See PR https://github.com/plone/documentation/pull/1664
@iFlameing There is a failing unit test which needs to be updated with a new snapshot that includes Hindi in the list.
@davisagli help! How to do that? It ain't in the Volto docs.
@stevepiercy There should be a prompt to update the snapshots when the tests are run as documented here: https://6.docs.plone.org/volto/contributing/testing.html#run-jest-tests-on-volto-core
@stevepiercy There should be a prompt to update the snapshots when the tests are run as documented here: https://6.docs.plone.org/volto/contributing/testing.html#run-jest-tests-on-volto-core
Done in db23888. Thank you!
I also noticed that https://6.docs.plone.org/volto/development/i18n.html#broad-overview mentions
.jsonfiles, and see that they are excluded from the repo in.gitignore. It's not clear what a developer should do with them or if there is some automation that takes care of it for the developer. Can someone enlighten me so I can update the docs accordingly?
If they are mentioned somewhere, it should be only as a "how does it work". Those JSON files are the .mo equivalent in gettext, you should forget they are there.