volto icon indicating copy to clipboard operation
volto copied to clipboard

Id widget refactor

Open Tishasoumya-02 opened this issue 1 year ago • 11 comments

#4460

Tishasoumya-02 avatar May 17 '24 06:05 Tishasoumya-02

Deploy Preview for plone-components canceled.

Name Link
Latest commit 98ca737ab373be1d7e380de657fa1678376532e7
Latest deploy log https://app.netlify.com/sites/plone-components/deploys/664ef06055bf550008012d60

netlify[bot] avatar May 17 '24 06:05 netlify[bot]

Deploy Preview for volto failed. Why did it fail? →

Name Link
Latest commit 5ab948f8bebba5c75e20ca20503190787f005711
Latest deploy log https://app.netlify.com/sites/volto/deploys/6646fac136cdfd0008dd550d

netlify[bot] avatar May 17 '24 06:05 netlify[bot]

@sneridagh It's not immediately obvious to me why the storybook build in the generator test is failing

davisagli avatar May 23 '24 00:05 davisagli

Should we be using yarn or pnpm to build the storybook? This one uses yarn, whereas we use pnpm for Volto docs when invoked by .readthedocs.yaml.

stevepiercy avatar May 23 '24 00:05 stevepiercy

@stevepiercy At present, we expect development of volto itself to be done using pnpm, but we still expect yarn for projects built by the volto generator, which is what that test is checking. (On the other hand, the new cookiecutter for volto projects sets up a project using pnpm.)

davisagli avatar May 23 '24 00:05 davisagli

Linkcheck fails because https://www.lanku.eus/ is not reachable. Site is by CodeSyntax, so @erral? I also sent an email to their info@ email.

stevepiercy avatar May 23 '24 01:05 stevepiercy

@davisagli let's see if it still fails, after updating with main.

stevepiercy avatar May 23 '24 01:05 stevepiercy

@stevepiercy Well, I assume so, since I updated it within the past hour and only merged one other unrelated PR since then.

davisagli avatar May 23 '24 01:05 davisagli

@davisagli does this error mean anything to you? I don't have a clue, and my DuckDuckFu does not lead me anywhere useful.

=> Failed to build the preview
SB_BUILDER-WEBPACK5_0002 (WebpackInvocationError): Module not found: Error: Can't resolve 'prop-types-exact/build/helpers/isPlainObject' in './node_modules/airbnb-prop-types/build/helpers'

stevepiercy avatar May 23 '24 01:05 stevepiercy

@stevepiercy No, it doesn't. That's why I asked @sneridagh about it above.

davisagli avatar May 23 '24 01:05 davisagli

Linkcheck fails because https://www.lanku.eus/ is not reachable. Site is by CodeSyntax, so @erral? I also sent an email to their info@ email.

site is up again!

erral avatar May 23 '24 04:05 erral

@davisagli LOL they're all green now, even though nothing really changed after @Tishasoumya-02 merged main to this branch.

I found this possible solution:

yarn cache clean

It appears that we use cache in our GitHub Actions, but I don't know whether that is related. For our future selves, we can clear caches from GitHub Workflows, if something totally inexplicable with GitHub Actions recurs again. Reference: https://stackoverflow.com/a/64819132/2214933

stevepiercy avatar May 23 '24 08:05 stevepiercy