David Taylor

Results 23 comments of David Taylor

> routeWillChange happens after the model hook is called Perhaps you're thinking of `routeDidChange`? My understanding is that `routeWillChange` is fired **before** any of the route model hooks (beforeModel, model,...

> in your example you're never aborting the current transition That's true. And indeed, if I add manual `transition.abort()` calls before each redirect, my test case succeeds. But still, this...

> ``` > output: { > filename: 'chunk.[id].[contenthash].js' > }, > ``` I tried this out in #548 to resolve the opposite problem - I was seeing identical chunk content,...

Please can you share a screenshot of what this looks like when the messages arrive in Telegram?

To make this save correctly, we need to add `custom_fields` to the values here: https://github.com/discourse/discourse/blob/46d1c91e1a0fd40110619b85bd2ed1623c70c6d0/app/assets/javascripts/discourse/app/controllers/preferences/notifications.js#L10-L19 This should be possible via the plugin API, using `modifyClass` to override the `init` function...

@xfalcox I guess this was resolved upstream? Good to close?

Underscores don't seem to make any difference out-the-box. Calling it `_item`, or `_` doesn't make any difference If I configure an eslint `argsIgnorePattern`, then underscored variables can be ignored: ```gjs...