David Taylor

Does this pass for the case that a domain has no MX records, but has a valid A/CNAME record? (I believe it should)

Superseded by #17873

We should add some tests to make sure this doesn't regress anything. Should possibly be delayed to 2.9 🤔

Yeah we really need to add some tests here - this is very sensitive code. Without them, I'm not convinced this PR is safe.

Thanks @Natureshadow, and sorry for the delay here. We'd be happy to accept this change, but we will need to add some kind of rspec test to make sure it...

You can simulate an API like this: https://github.com/discourse/discourse-chat-integration/blob/ae0389ca89f26401a6c4cffaaae6adcf14af0e15/spec/lib/discourse_chat_integration/provider/matrix/matrix_provider_spec.rb#L17 We use the `webmock` library for this: https://github.com/bblimke/webmock

I'm not aware of any recent changes to this area. I'd recommend checking: - Discourse's `auth_skip_create_confirm` site setting - that controls whether an account is created immediately, or whether the...

Going to close this for now, but please feel free to reopen if/when some tests are added.

Regarding the interop concerns, there is a fork of tracked-built-ins [here](https://github.com/ember-migration-utils/tracked-built-ins-compat) which has interop support for TrackedObject with the classic reactivity system. @dgeb and @wycats created it for us back...

@dependabot recreate