discourse-prometheus icon indicating copy to clipboard operation
discourse-prometheus copied to clipboard

DEV: Remove hardcoded Ruby GC tweaks

Open xfalcox opened this issue 2 years ago • 4 comments

xfalcox avatar Jan 19 '23 17:01 xfalcox

Do we know which of the tweaks breaks Ruby? We need to report this to https://bugs.ruby-lang.org/ - can you make it so?

SamSaffron avatar Jan 19 '23 22:01 SamSaffron

Do we know which of the tweaks breaks Ruby? We need to report this to https://bugs.ruby-lang.org/ - can you make it so?

While working on a minimal repro to fill the issue, found it was already reported at

https://bugs.ruby-lang.org/issues/19284

xfalcox avatar Jan 20 '23 15:01 xfalcox

@xfalcox I guess this was resolved upstream? Good to close?

davidtaylorhq avatar Apr 11 '23 08:04 davidtaylorhq

@xfalcox I guess this was resolved upstream? Good to close?

Upstream learned to ignore when the values are invalid. I would still lean on removing those if possible, but won't die on this hill

xfalcox avatar Apr 11 '23 16:04 xfalcox