Results 139 comments of David Schneider

For the sake of completeness: on ubuntu 20.04 you can get all clang-format version between 6 and 12. Upgrading is a good idea, though. The more interesting question is probably...

Here a summary (note that there are already quite a lot of changes removing the current ambiguity, i.e., the code does not exceed the column limit) - limit: 160: 329...

IIRC, @fsimonis also preferred 120. Then I will go for this option. > Btw: Do we have a limit on actual code? Because the title of this issue only says...

How does this change look like in our native bindings?

@boris-martin this was fixed by #1395, right? Do you still want to add the test or is it now already included?

In principle, this is bug of our configuration, as the data tag can not occur arbitrarily often https://github.com/precice/precice/blob/d83d3c789172acca414233bd65524297c4ce3438/src/acceleration/config/AccelerationConfiguration.cpp#L393 which does not match the implementation. I guess it was implemented for...

> We should stack the data vectors on top of each other (just as we do for QN) and implement this missing variant. This seems numerically odd as the dot...

Hm, this change introduced a `python-version`, which is supposed to be passed as an argument for the action setup. The action people write > The python-version input is optional. If...

We use `getMeshVerticesFromPositions` in the openfoam-adapter in order to [define connectivity](https://github.com/precice/openfoam-adapter/blob/bf38c42a197ca9b85b33cf16575010653cea53db/Interface.C#L266).