David Pedersen

Results 361 comments of David Pedersen
trafficstars

I filed a proposal for removing the old blanket impls https://github.com/tower-rs/tower/pull/657

Improving the general documentation around Tower is something I would like to drive. I have seen several cases on Twitter and Reddit where people say that Tower seems cool but...

@Folyd do you wanna drive this home?

Somewhat related: I tried porting axums `HandleError` to Tower but it has issues with backpressure https://github.com/tower-rs/tower/pull/593. I personally think the issues are fine for axum because of the limited use-case...

I think this is kinda interesting. Its not a need I've had myself previously. However, I don't believe its always valid to pass things around to different runtimes 🤔 I...

I'm not convinced this needs to live in tower rather than a separate crate given the gotchas but I could probably be convinced otherwise 😊 Would like to hear what...

> That said, I think we could start exploring a new trait on nightly w/ this addition. The ecosystem is getting in a solid spot now that we can focus...

Hm it feels like a bug to me that `Shared` doesn’t forward `poll_ready` to the inner service 🤔 although it would require adding a `S: Service` bound to fix, which...

@yaahc I would like to look into this but I can't quite reproduce it. Probably just something I'm misunderstanding. In this example the panic in `poll_ready` does get propagated back...

> If I had to guess why it looks like its working I'm guessing that the panic in the services is still printed to stdout by the panic handler before...