David Stone

Results 27 comments of David Stone

Congrats to all involved in this. It's a nice, useful feature. I do have some concerns about the following advice though: "Do not impose character limits unless there is a...

Just to clear up, I wasn't suggesting this new component be used with anything other than a text area. I just think the line: > "Do not impose character limits...

> Handling it in the backend and returning an error is a better user experience. Yeah @joelanman. Avoiding `maxlength` attributes and just relying on sensible limits in the backend error...

@paul-uz I believe https://github.com/nashwaan/xml-js already supports this via the "_instruction" key. This lib would need to expose that. I'm happy to issue a PR if I can work it out...

Brilliant! I actually looked over that file - not sure how I missed it! I'll let you know how the integration with my library goes, but so far they seem...

@Videl I would - yes please.

@Marsup this PR fixes [this issue](https://github.com/hapijs/joi/issues/3064) with the types around `LanguageMessages` and `Expression`s. ![image](https://github.com/user-attachments/assets/83df441b-1cca-489d-a162-228b86da529c) The 2nd arg of `Joi.expression` should allow for a `functions` map to be passed. Also, `LanguageMessages`...