David Wolinsky

Results 191 comments of David Wolinsky
trafficstars

Looks like we're moving the content to here: https://github.com/aptos-labs/whitepaper/tree/main/mandarin Happy to receive contributions over there

I'd rather our SDK be opinionated here and expect to generate the hash within.

> generating hash within requiring 1. a file as input and 2. committed to one hash algorithm. I would prefer those two can be optional and customizable. > I can...

@PaulFidika please run pre-commit or look at the lint issues: ``` diff --git a/aptos-move/framework/aptos-framework/sources/coin.move b/aptos-move/framework/aptos-framework/sources/coin.move index ec34d9c..ff016a9 100644 --- a/aptos-move/framework/aptos-framework/sources/coin.move +++ b/aptos-move/framework/aptos-framework/sources/coin.move @@ -810,7 +810,7 @@ module aptos_framework::coin { let...

install `pre-commit` and run it? I use arch linux, it was in aur, which I used `yay` to install. I think it is in brew for macs.

do you have plans to return to this? otherwise I can pass it off to someone else to wrap up.

I'm happy to land if we move this all to move-examples. I think to move forward as is, I'd think we'd probably need to review this a lot closer and...

Addressed in https://github.com/aptos-labs/aptos-core/pull/4598 The problem with trying to reinforce the create_address api is that this would break every single exchange / dapp out there and even if we did that...