David Hewitt
David Hewitt
As per the documentation you quoted, the general perception here is that properly written C code should also be respecting the `readonly` flag, and therefore it's ok to assume that...
I think you meant so say @Itamarst made the suggestion, but yes 👍
Agreed; I hope to prep the patch release tonight, will probably then put it live tomorrow.
Release is now live
> Is there a particular motivation for considering 1.74? There is nothing there that jumps out to me. I proposed just to match `cryptography`. Seems unreasonable to go higher than...
Looks like (so far at least) the tests pass ok. The codspeed report suggests to me that: - as above, we probably want to do this change alongside #4413 so...
The performance regressions seem to come from two cases: - Creating `PyErr` without the GIL now blocks on the GIL internally. I'm not worrried about this because I guess that...
Having rebased this, it's clear that this is still a pretty decent performance win across the codebase in general. With `Error` type for `FromPyObject` now implemented, with something for `&str`...
Thanks for the approval! Pushed a rebased commit, sorry for the delay.
Would be made irrelevant by #184