David Hewitt comments

Results 1495 comments of


                                            David Hewitt

pyo3-asyncio into PyO3 org?

We're approaching 3 months without an answer so I think it's time now to consider a permanent fork in the PyO3 organisation. Two thoughts: 1 - is anyone willing to...

pyo3-asyncio into PyO3 org?

Continued at https://github.com/PyO3/pyo3-async-runtimes/issues/1

Adds into_pyarray to faer Mat

Looks like this has hit a build issue with `faer`.

Adds into_pyarray to faer Mat

There still seem to be issues with Windows here. > If this is an issue, might have to either conditionally allow this optional faer feature, or, consider implementing IntoPyArray for...

Add support for Numpy 2.x

Continued by #442. Thank you all for the efforts in this PR and its follow-up!

invoking Python function that is implemented as a C extension module doesn't quite work

Thanks for the question. It's kinda unclear from the sample code you give above what went wrong, I see when you call `build_scaler` you wrote `self.build_scaler((scale,))` which I assume is...

Async pymethods returning result breaks "new" initializer method

Agreed, and in both of these cases we can probably improve the span and/or emit a better diagnostic.

Splitting value/python away from jiter's parser/decoders/iterators?

As of #184 I've removed the `LazyIndexMap` type. I think moving out the value into a `jiter-value` crate seems reasonable, eventually I may get to this as we refactor how...

Trailing singleton dimensions are removed during dtype conversion

Sorry for the slow reply. Your suggestion seems reasonable to me; if you're willing to provide a PR and tests pass seems right 👍

Install crashes on `ARM` with `Musl` (e.g. RPi + Alpine)

> Rust supports arm-unknown-linux-musleabihf as a "Tier 2" architecture. Despite "Tier 2" architectures being theoritically supported, at the time of testing, no pre-compiled toolkits were available for this platform. If...