David Hewitt
David Hewitt
I pushed a commit which should fix. The `&str` extraction only works like that on Python 3.9 and older, perhaps caused by your system Python? I am unsure why we...
I will give another pass at review probably on Sunday.
Looks like the `&str` case in the UI test is indeed still a problem. I'm currently investigating that code to see what we can do to improve the error message.
Circling back here, I have some ideas how to solve that problem, but the async code being heavily special cased (xref #5681) is causing issues for me. If I get...
A couple of extra ideas: - Link from performance section to parallelism section (just to help visibility) - `.extract::()` cloning vs `.extract::()` taking a reference (for `#[pyclass]`)
Error creation e.g. `PyErrArguments`, how to avoid lazy error construction etc.
@samuelcolvin we added that as the initial content of the performance section already 😉 https://pyo3.rs/main/performance#extract-versus-downcast
I think it's because the extraction code is creating `PyClassGuard` containers with some lifetime which is not `'static`. I am unsure if we can work around this, experimentation needed.
I think it's potentially possible if the argument extraction happens inside the future rather than outside. The only downside I can see would be that all input arguments are currently...
Sorry this change bit you. Are you able to share any detail about the patterns where this ended up problematic? We had some discussion of this change in https://github.com/PyO3/pyo3/issues/4041#issuecomment-2041074534 and...