rust-numpy icon indicating copy to clipboard operation
rust-numpy copied to clipboard

Adds into_pyarray to faer Mat

Open wgurecky opened this issue 10 months ago • 4 comments

Interoperability with faer (https://github.com/sarah-quinones/faer-rs) Mats.

Related faer-ext PR for numpy-to-faer direction: https://github.com/sarah-quinones/faer-ext/pull/6 . For bi-directional interoperability of faer with python/numpy. @sarah-quinones

wgurecky avatar Mar 10 '25 01:03 wgurecky

Looks like this has hit a build issue with faer.

davidhewitt avatar Mar 13 '25 21:03 davidhewitt

Looks like this has hit a build issue with faer.

yes, on windows x86 :/ . I don't have a good way to test on windows locally. Looks like a small change is needed in the faer-traits crate.

wgurecky avatar Mar 14 '25 16:03 wgurecky

Looks like this has hit a build issue with faer.

Updated to the latest faer version which contains a fix for this build issue.

There is a second issue, however. faer requires msrv of 1.84.0. If this is an issue, might have to either conditionally allow this optional faer feature, or, consider implementing IntoPyArray for faer Mats in faer itself

wgurecky avatar Mar 18 '25 20:03 wgurecky

There still seem to be issues with Windows here.

If this is an issue, might have to either conditionally allow this optional faer feature, or, consider implementing IntoPyArray for faer Mats in faer itself

Given the seeming complexity with the CI on this end, this may be simpler (esp if faer has already implemented the reverse conversion over there).

davidhewitt avatar Mar 20 '25 19:03 davidhewitt