David Hewitt
David Hewitt
I'm open to this, can you maybe elaborate a bit further? I think you're right that ripping the lazy state out is maybe more breaking than I originally considered, so...
#4764 makes me more convinced that we need to take the "lazy" state out - while in the particular polars case there the exceptions are coming from Python and don't...
My thoughts I didn't have time to add earlier: ### Adding the parameter name > I was looking into this and I think the biggest issue is that the extraction...
Awesome, many thanks for taking this up! (For those interested, discussion has continued on #1212.)
I think this issue should probably be closed for two follow ups I'd like to see: - our type names printed in error messages are `PyTuple`, `PyStr` etc. It would...
Can you share an exact commit which contains an example of the broken behaviour? That would be a great help with reproduction of the bug.
Worth bringing up an old concern by @mejrs in a related topic that `*` has a different meaning in Rust: https://github.com/PyO3/pyo3/issues/1463#issuecomment-838402393 We do already have `pyo3(signature = (*args, **kwargs))`, so...
> If `*args` and `**kwds` are allowed to be used the Python sense, I think no Rust syntax should be allowed at all - i.e. all parameter values need to...
Thanks all. Yes to all the above - will do my best to round-robin reviews for all of the above! 😄
Yes, thanks again to all involved!