David Hewitt

Results 1495 comments of David Hewitt

I think `pyo3_bytes::PyBytes` gets passed to Python as a real Python type; we haven't got a great story (yet) for doing those kind of centralised reusable types in the PyO3...

Closing in favour of #5252

Thanks very much all!

I think that's not a suprise that it's hard to segfault; you'd have to do something like turn the uninitialized read into a cast on the bytes to create a...

Thanks for that. I'm a bit unsure what the way forward here is. Without upstream also using critical sections, as you observe, adding the single section here seems a bit...

With 3.14 now well into the beta phase, I think we should proceed with merging this. @robsdedude do you have any remnants of that test you previously wrote?

Thanks! I would make it such that if `ser_json_temporal` is set, use that value, otherwise use `ser_json_timedelta` value (where applicable). That should make it non-breaking for existing users while adding...

> As a note the validation part of this seems a lot more complicated so may take a bit (lot) more time to implement.. hopefully supporting this first isn't too...

Sorry for dropping the ball here - will seek to complete review of both these PRs by EOD tomorrow.

It sounds like for some reason the `abi3` PyO3 features are enabled. Can you please go into more detail about how you are configuring the build?