David Hewitt
David Hewitt
Good idea, milestone created, will leave this in draft until then I guess.
Ok, CHANGELOG added, maybe we merge this just in time for 0.24? :)
I will aim to improve this in https://github.com/pydantic/pydantic-core/pull/867 (I will see if it's possible to prefer the Enum class if possible.)
cc @ngoldbaum
Yes agreed, I considered changing `PyRef` but would prefer to delay given there's enough breaking changes coming in 0.23. I also want to be careful with changing `PyRef` right now...
Great, will merge this. I am considering landing this as part of a stack of fixes in a 0.22.3 patch.
I guess we wouldn't need to store any state where the borrows happen at least? We could just slap `#[track_caller]` on a bunch of methods and then use the location...
Right, sorry, I think I called out the wrong commit as the regression. There's a slightly older PR (#30316 3 weeks) which removed some logic to hide underlines for unused...
> Alternatively, we could show underlines with inactive fade only if the diagnostics level is higher than a certain level, but I feel this is arbitrarily chosen and probably better...
Sorry for the delayed reply. I think contrast is probably a feature of user theme choice? Here's some screenshots to maybe answer: zed commit 1445af559b22ceec87bbad419ecbb4e07e6d2c07:  zed with my patch...