pyo3 icon indicating copy to clipboard operation
pyo3 copied to clipboard

remove `Deref` implementations for old "gil refs" types

Open davidhewitt opened this issue 1 year ago • 2 comments

Follow-up on https://github.com/PyO3/pyo3/pull/4589#discussion_r1787491912

I'm open to whether this needs a CHANGELOG entry... I guess it does because it can affect type bounds (e.g. as it does in this PR). Maybe that's a good reason to park this until 0.24 as a low-ish priority (breaking) change, that's easier the longer ago GIL Refs died.

davidhewitt avatar Oct 04 '24 10:10 davidhewitt

Yeah, it probably deserves a changelog entry. Targeting 0.24 seems fine to me. Do we want to add a milestone to track that?

Icxolu avatar Oct 04 '24 11:10 Icxolu

Good idea, milestone created, will leave this in draft until then I guess.

davidhewitt avatar Oct 04 '24 11:10 davidhewitt

Ok, CHANGELOG added, maybe we merge this just in time for 0.24? :)

davidhewitt avatar Mar 07 '25 08:03 davidhewitt