David Brochart

Results 1131 comments of David Brochart

Failures seem to be caused by the latest release of AnyIO. In this [PR](https://github.com/agronholm/anyio/pull/715), AnyIO now emits a `ResourceWarning` on unclosed memory object streams. So we should either explicitly close...

This is happening in `pycrdt-websocket`. Another (temporary) option would be to pin `anyio

Thanks. I guess we should update the screenshots in the UI tests, as we did in `3.x`?

@fcollonval there are conflicts, sorry for not merging earlier. Do you want to rebase?

Thanks @Meriem-BenIsmail for looking into this. I think we need to clarify what we mean by read-only documents: - in non-RTC mode, this currently means that users cannot save to...

> The design principle with most document editors is that when file is not writable user is still allowed to edit it and save to a different file. That's fine...

Permissions are at the Jupyter server API level, and jupyter-collaboration uses WebSockets so it could use this information. But we are talking about different things here, filesystem permissions vs user...

I'm thinking that as soon as the user changes the document while navigating the history, this should create another fork of the (forked) document, but this time from the current...

That would be good to have in pycrdt, but I'm not sure when I can find time to do it. A PR would indeed make it happen sooner.

It looks like we have a [PR](https://github.com/jupyter-server/pycrdt/pull/184) :rocket: