David Brochart

Results 1133 comments of David Brochart

Just a minor update to docs, and I think it's good to go! Do you want to squash a little bit, especially to get rid of https://github.com/jupyter-server/jupyverse/pull/239/commits/1653b7eb8ac364d48b9b7a57ef38811f35309654?

I think you deserve more credit, thanks a lot for your contribution @RobertRosca ! It looks like tests hang on windows for python >=3.8, I'll merge and investigate later.

Thanks for reporting @giswqs, I guess the time has come to have tests in xarray-leaflet! I will try to work on this soon.

That would be great @robintw! I think it would be nice to have some tests in the CI. I can imagine using [Galata](https://github.com/jupyterlab/jupyterlab/tree/master/galata) to open a headless browser and execute...

For an example of UI testing using Galata, see https://github.com/jupyter-widgets/ipyleaflet/pull/905.

xarray-leaflet got its first test in #49 !

What do you mean with "rioxarray not compliant with zarr format"? After loading your zarr array, you should set the CRS and nodata if they are not already set: -...

Maybe you should [open the Zarr store with xarray](http://xarray.pydata.org/en/stable/user-guide/io.html#cloud-storage-buckets) (replace `gcs` with `s3`): ```python ds_gcs = xr.open_dataset( "gcs:///path.zarr", backend_kwargs={ "storage_options": {"project": "", "token": None} }, engine="zarr", ) ```

> I concluded from your example that rasterio was mandatory. You're right, it *is* mandatory to set the CRS and nodata, but this can be done after loading your array....