David Bakin
David Bakin
With the Cancun upgrade (targeted: services 0.50) there should be examples of some Cancun functionality in the smart contract repo. And they can also serve, perhaps, as end-to-end tests of...
### Problem Current javadoc at `SlotKey.contractID` isn't clear (IMO!) that the `ContractID` must be a `contractNum` and never an `evm_address`. IMO "number of the contract" doesn't _directly_ relate to the...
There are configuration items for `SEND_RAW_TRANSACTION_SIZE_LIMIT`, `FILE_APPEND_MAX_CHUNKS`, and `FILE_APPEND_CHUNK_SIZE`. `FILE_APPEND_MAX_CHUNKS` can (and should) be computed from the other two. So it can be eliminated as a config variable, and maintainer...
Documentation at https://docs.hedera.com/hedera/sdks-and-apis/sdks/token-service/custom-token-fees, specifically: > Fixed Fee: Paid by the sender of the fungible or non-fungible tokens. A fixed fee transfers a set amount to a fee collector account each...
Need a "guidelines"/"best practices" document for how to specify system contract APIs going forward
Can't change the past, but we can be more consistent going forward. We've ~made mistakes~ have current APIs which could have been done better. Some things that could be included:...
Currently each system contract translator has it's own way of matching the method selector. Instead, have an `AbstractCallAtttempt.isSelector(Function method, AbstractCallAttempt attempt` to do this and refactor to use it throughout...
At any given time the `contracts/system-contracts` directory holds the _current_ definitions of system contracts - methods and structs. And that works for most developer who want to compile contracts that...
Need examples (that also serve as tests) for `isAuthorizedRaw`.
It's only for returning information. Should be documented as such so that we don't forget in the future and try to use it as an input.
Given the (new) raw bytecode analyzer script and slither tools, provide small wrappers to do operations on multiple contracts at a time. Input would be a file containing a list...