David Allison

I've had a quick Google, but no obvious annotations came up to tell the kotlin compiler that the Java list should be `List` rather than `MutableList` when accessed by Kotlin...

Sounds correct

needs rebasing onto `main` & de-conflicting

I have animations disabled in the Developer settings, this doesn't handle that case.

I don't believe we have the functionality yet. To enable on your device: https://www.androidpolice.com/how-to-speed-up-animations-on-your-android-phone/

All 3 EDIT: Tried again. Failed with the same error as in the unit tests: ``` 2023-03-04 03:49:22.072 19988-19988 MessageQueue-JNI com.ichi2.anki.debug E android.provider.Settings$SettingNotFoundException: window_animation_scale at android.provider.Settings$Global.getInt(Settings.java:15261) at com.ichi2.anki.DeckPickerFloatingActionMenu.deviceAnimationEnabled(DeckPickerFloatingActionMenu.kt:69) at com.ichi2.anki.DeckPickerFloatingActionMenu.showFloatingActionMenu(DeckPickerFloatingActionMenu.kt:88)...

@BrayanDSO fixed in e04d9be7cdab47044057ddd9f07ef634bb99e382 ?

@user1823 we've done some work here. Is there anything still remaining?

Seeing this on the legacy backend: ``` java.lang.UnsupportedOperationException: ListIterator does not support set at org.apache.commons.collections4.list.SetUniqueList$SetListListIterator.set(SetUniqueList.java:5) at java.util.Collections.sort(Collections.java:247) at kotlin.collections.CollectionsKt__MutableCollectionsJVMKt.sortWith(MutableCollectionsJVM.kt:18) at kotlin.collections.CollectionsKt.sortWith(Unknown Source) at com.ichi2.anki.dialogs.tags.TagsList.sort(TagsList.kt:13) at com.ichi2.anki.dialogs.tags.TagsArrayAdapter.sortData(TagsArrayAdapter.kt:3) at com.ichi2.anki.dialogs.tags.TagsArrayAdapter.(TagsArrayAdapter.kt:18) at com.ichi2.anki.dialogs.tags.TagsDialog.onCreateDialog(TagsDialog.kt:67)...

Relevant: #8807 https://github.com/ankidroid/Anki-Android/blob/a06e727f6094541b763e2dc18a300edb3e17fd26/AnkiDroid/src/test/java/com/ichi2/anki/dialogs/tags/TagsListTest.kt#L489-L507