Dave Waggoner
Dave Waggoner
Thinking about this more, it would be simpler, more dependable, and still give us the test coverage we are looking for here to have these tests just call Terminal::mouse_* methods...
In local testing, it doesn't seem to work anymore? One of our refactors must have regressed the feature... interesting...
Yeah, it's working for me too now... I must have done something dumb earlier... 🤷♂️
@cla-bot check
Thanks for checking in, I'll give it a quick self-review and fix/tidy anything I notice, then I'll take it out of draft.
Okay, this is ready for review. Although, if it is possible to pickup the fix for https://github.com/alacritty/alacritty/issues/8586, I'd be tempted to do that first so that all the custom columns...
Thanks for reviewing this! I don't feel strongly about the HyperlinkFinder vs RegexSearches style, so I'll refactor it to RegexSearches as you describe.