Add new terminal hyperlink tests
Part of #28238
This PR refactors FindHyperlink handling and associated code in terminal.rs into its own file for improved testability, and adds tests.
Release Notes:
- N/A
We require contributors to sign our Contributor License Agreement, and we don't have @davewa on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.
@cla-bot check
The cla-bot has been summoned, and re-checked this pull request!
Hey, how's this going? Is it ready to no longer be a draft? Or are you still working on it? Happy to help if needed/wanted :)
Thanks for checking in, I'll give it a quick self-review and fix/tidy anything I notice, then I'll take it out of draft.
Okay, this is ready for review. Although, if it is possible to pickup the fix for https://github.com/alacritty/alacritty/issues/8586, I'd be tempted to do that first so that all the custom columns in these tests can be removed.
Thanks for reviewing this! I don't feel strongly about the HyperlinkFinder vs RegexSearches style, so I'll refactor it to RegexSearches as you describe.
Looks good! Going to enable the CI runs, but other than CI passing, I think I'm ready to merge when you are. Thanks!
This turned out great. Thanks again!