zed icon indicating copy to clipboard operation
zed copied to clipboard

Add new terminal hyperlink tests

Open davewa opened this issue 8 months ago • 7 comments

Part of #28238

This PR refactors FindHyperlink handling and associated code in terminal.rs into its own file for improved testability, and adds tests.

Release Notes:

  • N/A

davewa avatar Apr 10 '25 17:04 davewa

We require contributors to sign our Contributor License Agreement, and we don't have @davewa on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

cla-bot[bot] avatar Apr 10 '25 17:04 cla-bot[bot]

@cla-bot check

davewa avatar Apr 10 '25 18:04 davewa

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Apr 10 '25 18:04 cla-bot[bot]

Hey, how's this going? Is it ready to no longer be a draft? Or are you still working on it? Happy to help if needed/wanted :)

probably-neb avatar May 22 '25 08:05 probably-neb

Thanks for checking in, I'll give it a quick self-review and fix/tidy anything I notice, then I'll take it out of draft.

davewa avatar May 24 '25 14:05 davewa

Okay, this is ready for review. Although, if it is possible to pickup the fix for https://github.com/alacritty/alacritty/issues/8586, I'd be tempted to do that first so that all the custom columns in these tests can be removed.

davewa avatar May 30 '25 14:05 davewa

Thanks for reviewing this! I don't feel strongly about the HyperlinkFinder vs RegexSearches style, so I'll refactor it to RegexSearches as you describe.

davewa avatar Jun 04 '25 13:06 davewa

Looks good! Going to enable the CI runs, but other than CI passing, I think I'm ready to merge when you are. Thanks!

probably-neb avatar Jun 06 '25 09:06 probably-neb

This turned out great. Thanks again!

probably-neb avatar Jun 06 '25 12:06 probably-neb