Dave Kay comments

Results 22 comments of


                                            Dave Kay

We have governor public, and a getter called getGovernor

no i didnt, i remember seeing that open zepplin made a suggestion to fix this too

We have governor public, and a getter called getGovernor

Oh i remember, you are right. yeah lets move it to private

Grace period after maxAllocationEpochs on closeAllocation by delegator

maybe. i am always against more params though, unless absolutely necessary. my gut feeling is we could do without it. a rational indexer should just close on time. and the...

Support for calling Ether Balances in mappings

yes still yet to be implemented :(

Feature Request: Support indexed argument filtering

I vaguely remember that the reason that `indexed` was introduced was that when a type with a variable size such as a `string` is `indexed`, the `topic` is the hash...

Move helpers from contracts to common-ts

@nenadjaja @Jannis

Subgraph does not contain the GraphProxyAdmin address

its basically just adding a field on `graphNetwork` and then saving the address It wouldnt hurt to have it but also we've never needed it

queryFeesCollected should be more or equal (queryFeeRebates + delegationFees)

Thank you! Great investigation work. I took a quick look but could not find anything. Seems like it could be a bug . I am too busy this week to...

queryFeesCollected should be more or equal (queryFeeRebates + delegationFees)

Unfortunately, no that relationship is not correct. The cobbs douglas formula (i.e. the reward formula), will return query fee rebates that could be very different from the query fees collected....

Query Fees Collected - does not match estimation

@davaymne Hey, I am well versed in the Subgraph part, but not the logs you have shared as I don't deal much with graph-node. Are the logs you shared query...