We have governor public, and a getter called getGovernor

[davekay100]

trafficstars

We have on Controller:

address public governor;

and

    /**
     * @notice Getter to access governor
     */
    function getGovernor() external override view returns (address) {
        return governor;
    }

We can use just one. Which one do you like @abarmat ?

[abarmat]

I would just use governor()

[abarmat]

@davekaj dave did you do this change? I don't remember

[davekay100]

no i didnt,

i remember seeing that open zepplin made a suggestion to fix this too

[abarmat]

Now that I see the code I think we included that so we could add the getter to the interface because it is used in Managed.sol

Maybe we could keep the getter but move governor to be private

[davekay100]

Oh i remember, you are right. yeah lets move it to private