Dave Jeffery
Dave Jeffery
Followed on from this in #68. I would appreciate it if you take a look @mihar-22. Just one item remaining, if you give me some clarification then I should be...
Also encountered this.
FYI: This can also happen when you try to show a banner before the active view (`ion-view[nav-view="active"]`) is in the DOM.
I have `$ionicContentBanner.show()` in a controller but `ion-view[nav-view="active"]` isn't created yet when `$ionicContentBanner.show()` is called and I got the error described above. The error goes away if I put the...
Yeah I understand the issue. I fire the function call on the `$viewContentLoaded` event now so it's not an issue anymore. Perhaps the plugin could wait for the loaded event...
@juliangruber: wrong Dave you've mentioned 🙂
@zeke Ok, I could have a go at the JavaScript stuff. I think the collapsible release notes would require changes to Electron core and some C code though. Any tips...
Windows also has the concept of collapsible text in a dialog. Perhaps this would be a useful addition to Electron core? It's much nicer UX than plonking all the release...
Happy to review and merge PRs if anyone wants to make a start.
@pixelass Yes, I would be happy to review any contributions.