kit-docs icon indicating copy to clipboard operation
kit-docs copied to clipboard

pnpm dev working

Open slowsage opened this issue 3 years ago • 2 comments

~~This is a best effort to migrate to the new routing system covering kit-docs (not the create module). I got the sidebar working and a lot of other small things. It may help you finish the integration. There are 3 unresolved issues:~~

  1. ~~There is one issue with pnpm build - it needs the Response type in the node/handler.~~
  2. ~~Run pnpm dev. There is a layout issue~~ fixed
  3. ~~shiki config may need to be fixed for various languages.~~ Added languages manually. Not sure what the correct approach is.

I think I fixed all the major issues. kit-docs package seems to be working.

Thank you

slowsage avatar Oct 16 '22 22:10 slowsage

Oh wow, thank you so much @slowsage. I'll pull it down and have a quick look now.

mihar-22 avatar Oct 17 '22 00:10 mihar-22

It's an awesome start! Not much left to go:

  • I updated create package to align with your changes. Need to test if it still works.
  • demo package has to be updated.
  • links resolution is wrong as it's resolving named page routes (i.e., index.svelte instead of +page.svelte). This is mostly in the node/handlers/index.ts file.
  • The glob in sitemap.xml seems to not be picking up an files strangely.

I think that's about it, I'll have another look tonight and see what else I can add in. Thank you again slowsage.

mihar-22 avatar Oct 17 '22 01:10 mihar-22

Followed on from this in #68. I would appreciate it if you take a look @mihar-22. Just one item remaining, if you give me some clarification then I should be able to fix that too.

davej avatar Dec 06 '22 00:12 davej

PR is continued here:

https://github.com/svelteness/kit-docs/pull/69

mihar-22 avatar Dec 11 '22 04:12 mihar-22