Dave Jeffery

Results 100 comments of Dave Jeffery

Thanks @mmaietta, I did some testing. It seems that `yarn run install` was a way of forcing yarn to run install scripts and rebuild the module in Yarn 1. However,...

@mmaietta I'm getting reports of this affecting more customers. Is there anything that I can work on that would help with this? Perhaps some way to easily switch between @electron/rebuild...

@mmaietta Thanks! I tried this and it seemed to work but when I return `false` from the `beforeBuild` function then the app that is output had no `node_modules` directory in...

This seems to be the problem: https://github.com/electron-userland/electron-builder/blob/538dd86bf52f0091dbb1120bdd30f56dfdbd5747/packages/app-builder-lib/src/platformPackager.ts#L389 If I hardcode `this.info.areNodeModulesHandledExternally` to `false` then the app builds correctly and includes `node_modules` in the output directory. ```diff - if (!this.info.isPrepackedAppAsar &&...

> Can you try giving that a shot? I suppose that would mean running the command via `npx electron-builder ` I'm not sure that I understand. The solution that I...

> I'm not too big a fan of adding another property to the config, but am open to the idea if we're unable to make progress with [develar/app-builder#103](https://github.com/develar/app-builder/issues/103). Tbh, I...

Got it, thanks for the context Mike! Even if the upstream Yarn bug gets fixed then I imagine that some users might still like to use `@electron/rebuild` to rebuild the...

> Hmmm, that would be a breaking API change for users, so I'm cautious in doing that. I presume you're referring to the `beforeBuild` return value? It might technically be...

Hey @Jamie0, I'm super happy to give feedback on and ultimately merge a pull request that would fix this, if you're interested? I think it's unlikely that any of the...