Dave Cheney

internal/grpc: move filtering of Values to Register

5

Currently the grpc package and xds handler can filter results returned by `cache.Values` by a filter constructed from the DiscoveryRequest. However the `cache.Register` method lacks a way of filtering notifications...

Instructions for presenting grpc services needs a guide

25

We need a guide that concisely describes the HTTPProxy configuration and service annotations required to proxy grpc through contour.

internal/contour: ingressroute/httpproxies outside --root-namespaces create empty route sets

1

#2106 suggested that in some cases an ingressroute/httpproxy outside the root namespace set could cause empty records to be created in RDS. This behaviour is unexpected. I would expect that...

TLS certificate fixtures are duplicated many times

1

There are at least three sets of TLS certificate fixtures in the codebase. Ideally there should be one.

Header.Contains tests lack tests

2

Header Contains conditions that result in a regex matcher are not tested. Tests at the `internal/contour` and `internal/featuretest` level should be added.

internal/dag: add explicit check that virtualhost.TCPProxy is never overwritten.

8

There should be compensating controls that ensure when a HTTPProxy TCPProxy is processed we never overwrite the TCPProxy value on the resulting securevirtualhost. But that's not stated explicitly, or tested,...

internal/dag: duplicate inclusion / delegation loop logic in builder.go

1

There are four copies of the logic to detect inclusion / delegation loops. It should be factored out.

Currently if a certificate is missing or invalid we report "missing or invalid" in the status block. Missing is self evident, but invalid is defined by the validation function passed...

/healthz endpoint should record statistics

5

our /healthz endpoint returns an error to the client if the k8s ping fails but does not record that fact on contour. I don't want to log this at the...

Currently we test the DAG builder's output via `buider_test.go`, we also test the status output via `status_test.go`. Both of these tests do the same thing -- take some k8s objects,...