contour
contour copied to clipboard
projectcontour
/healthz endpoint should record statistics
our /healthz endpoint returns an error to the client if the k8s ping fails but does not record that fact on contour.
I don't want to log this at the contour level as it could cause log spam if the health check is flaky.
We should add metrics around this.
- [ ] /healthz hits
- [ ] successful responses
- [ ] unsuccessful responses
@IngCr3at1on go for it. Please discuss your design here or in a design document before coding. Thank you.
@davecheney yep.. I realized right after asking that I was leaving on a vacation but I looked at it a bit, doesn't look too bad will take another look and get something written up here.
Requires changing internal/metrics/metrics.go
func registerHealthCheck(mux *http.ServeMux, client *kubernetes.Clientset) {
to
func registerHealthCheck(mux *http.ServeMux, client *kubernetes.Clientset, registry *prometheus.Registry) {
and change
registerHealthCheck(&svc.ServeMux, svc.Client)
registerMetrics(&svc.ServeMux, svc.Registry)
to
registerHealthCheck(&svc.ServeMux, svc.Client, svc.Registry)
registerMetrics(&svc.ServeMux, svc.Registry)
before creating the handler function in registerHealthCheck register the 3 required gauges for health and adjust these directly from the handler function.
Needs a separate table test in internal/metrics/metrics_test.go using httptest.