Dave Collins

Why are all of the modules being updated to require go 1.21 when they don't actually require it?

For anyone reading later, we had a discussion about this in the development channel on matrix since github was down at the time. The summary is that there doesn't seem...

For some additional details from the chat channel where I looked at the code a bit: > I'm not entirely sure since it's not my area, but a quick look...

For those of us who are tech savvy, an encrypted filesystem is indeed the best approach, but it's also just not very realistic for users to do. I really don't...

Glad to see this! I did notice the dependency has various inefficiencies looking through it, but given that it won't be used in any type of hot paths, that is...

I followed up a bit on [this comment](https://github.com/decred/dcrdex/pull/2936#discussion_r1743080791), but it's resolved, so I figured I'd post a link to it here so it doesn't get missed.

> "Tx sync" may be confusing. Maybe something like "wallet scan" or "wallet sync"? I don't know. Balance Discovery?

> It looks like Cryptofuzz has already found two issues similar to those we found in our fuzzing. > > https://github.com/MozillaSecurity/cryptofuzz/blob/3d2377257129fc5da6effb92b0736e31db147dee/modules/decred/cryptofuzz.go#L238-L243 > > 1. They skip if the private key...

In general, I'd suggest something like the following wrapper code any time you are trying to use raw bytes that are not already known to be a valid private key,...