Dave Collins

It's still the case, but realistically it's been 7 years and nobody really seems to care too much. That said, there is tool for this nowadays that could be used...

I think having `{add,delete}miningaddress` and `listminingaddresses` makes fine sense. I haven't reviewed the code yet, but should be able to get it reviewed later this week.

Thanks for the updates. One thing I noticed is the second commit converts the `MiningAddr` config field option from `[]string` to `string` and I definitely don't think that should be...

I forgot to mention in my review that I really like the idea here. It allows miners to avoid downtime when changing things which is quite important for them. It...

So, I believe I know why you changed the `preCfg := cfg` copy to `preCfg := &cfg` originally which is the following vet error: ``` config.go:377::error: assignment copies lock value...

Nice job overall as usual! Also, this needs a rebase to correct the conflicts.

Now the segwit has been merged, would you please rebase and update this to take care of the final review comments? Thanks @Roasbeef!

Commenting here because I just saw @Roasbeef's tweet linking to it. FYI I implemented something similar in dcrd back in 2019 in what is imo a simpler way and should...

Very nice! Thanks a ton for working on this. It's obviously going to take a lot of careful review and there are some Travis issues to take care of, but...

There are several issues reported by Travis that need to be resolved before this can be merged as well: ``` btcec/btcec.go:643:2: should replace c2.n[0] += 1 with c2.n[0]++ btcec/internal_test.go:91:21: exported...