decred
ui: incorrect Build ID displayed (in settings)
I've noticed the Build ID string displayed in UI doesn't seem to match the actual commit it is presumably supposed to reflect, for example for v1.0.2 it shows 1fd2fce (I'm not sure where this value comes from, couldn't find it on Github):
For some additional details from the chat channel where I looked at the code a bit:
I'm not entirely sure since it's not my area, but a quick look at the code looks like it's pulled in when the templates are built into the html files. The resulting files are checked into the repo for releases. So, it'll be whatever commit whoever the dev that built them was on when they built them. That approach means it can never match the commit hash of the release commit, because the hash can't be known before the commit is created given putting the hash in the commit would itself change the commit hash.
I would guess it was built on a commit that was later rebased and why you don't see it searching like that.
At any rate, I see it (the commit hash) in the release js code as I deduced from reading the surrounding code. Search for it in there.
Another remark I made in the dex dev channel:
I'm curious why it's being done via the HTML and webpack files like that at all. It would be nicer to simply populate the template from Go which can easily get the hash from the runtime/debug info like dcrd and dcrwallet do it. See code to pull it here. Unless the intent is to have the commit that was used to build the populated html files themselves, but then that shouldn't be confused with the software build ID / commit hash as it is now.
