Philipp Daun

Results 123 comments of Philipp Daun

This would also help with patching the library. I currently have to maintain a patch that uses a different base64 algorithm and it's quite messy patching a minified JS file....

@hirasso Any reason you've removed the comment about adding support for relative links and the base tag? I think it's a nice goal to support everything the browser natively supports...

Huh. I didn't know `./something/` was a valid URL, I've always assumed `something/` to be the correct way of resolving from the current path. In any case, the nice thing...

Interesting! You're right that swup will work even without transitions. It wasn't meant to initially — until a few versions ago, swup would fail if no transitions were defined; we've...

@mskocik That's actually a good idea, we might consider adding log verbosity levels to fine-tune the behavior. However, it's not something that's on the near horizon.

@gmrchk The more I think about it, allowing `false` as a selector is probably the most elegant solution. It signals intent, won't happen by accident and will be a simple...

I've just merged #521 to allow passing `false` as the animation selector and suppress the warning. It'll be released as part of swup 3.0 which is currently taking shape in...

@hirasso Feel free to check out the current state of the branch. Looking forward to your input on the API, naming and handling of edge cases.

@hirasso I've merged the `next` branch into this one. It does compile, but let me know if something's funny.

> Some people might be overwriting some of the internal methods like `leavePage` or `renderPage` of Swup to do a custom handling, in which case things will break if any...