Results 39 comments of J

Just adding an additional note here, we're seeing this warning a lot now that we're using ViewComponent (https://github.com/github/view_component). The warning is definitely a false positive, but it's using a parameter,...

We're having a similar issue where the upgrade from 1.7.1 to 1.9.0 has started raising exceptions like the following: ``` ArgumentError - Cannot parse calc(1em * 8 / 4) auto...

I've pushed a PR that fixes the issue I had in #126. I believe these issues aren't related so perhaps I ought to open up a new issue, but when...

@grosser It never really worked, but it was often silently ignored until the commit in 8868aa69eb4369161a89765df11ab2537915c968, specifically with this code: https://github.com/premailer/css_parser/blob/master/lib/css_parser/rule_set.rb#L373 The issue being if the value is being split...

I added the following to my base `ApplicationInteractorContext` class from which I inherit all of my interactor contexts and it restores the previous behaviour. Now I just have a bunch...

There is also a deprecation that states the following for classes inherited from `Liquid::Rails::Drop`: ``` DEPRECATION WARNING: ActionView::Base instances should be constructed with a lookup context, assignments, and a controller....

It's been a while since I worked on the code, but I think the basic gist of it had something to do with the way that polymorphic slot names are...

@jklina @jonspalmer I believe you'd be able to combine both the use of helpers with nested components using the following addition to this PR: https://github.com/dark-panda/view_component_storybook/commit/ec07f4261d16e6608d3562f7808819056358e8b7

Cheers, I'll give this a shot soon to see how it looks on my end.

Yeah, looks like older versions of Ruby aren't fans of that hash syntax. I'll fix these up and reroll shortly, shouldn't be a problem.