liquid-rails icon indicating copy to clipboard operation
liquid-rails copied to clipboard

Rails 6.0.0.rc1 deprecation

Open axlekb opened this issue 6 years ago • 3 comments

Hello! Looks like Rails 6 has a slight change in template handler signature.

DEPRECATION WARNING: Single arity template handlers are deprecated. Template handlers
must now accept two parameters, the view object and the source for the view object.
Change:
  >> Liquid::Rails::TemplateHandler.call(template)
To:
  >> Liquid::Rails::TemplateHandler.call(template, source)
 (called from <top (required)> at <...>/config/environment.rb:7)

axlekb avatar Jun 03 '19 12:06 axlekb

@chamnap Any thoughts on this?

richardonrails avatar Nov 04 '19 01:11 richardonrails

There is also a deprecation that states the following for classes inherited from Liquid::Rails::Drop:

DEPRECATION WARNING: ActionView::Base instances should be constructed with a lookup context, assignments, and a controller.

This is on Rails 6.0.2.

dark-panda avatar Dec 19 '19 17:12 dark-panda

The fix is easy even though this is not maintained anymore. Just fork it and make this change:

https://github.com/aquaponics-ai/liquid-rails/commit/47133f7536822851a24bd71fad5cfffa69b4b1bc

panbanda avatar Oct 27 '20 19:10 panbanda