Dario Piotrowicz
Dario Piotrowicz
I'm wondering, does the `async` pipe need to emit `null` before checking the condition? :thinking: Could for example a startWith-like argument be added to the pipe instead? so that the...
> Thanks Dario, is this ready for review? Yes :smiley:
> Mind rebasing and reformatting for lint? I will run a presubmit and find a reviewer done, thank you very much! :smile: :pray:
> @dario-piotrowicz thanks for creating this PR. We've reviewed the changes and there are some potential risks related to the extra processing. We'd need to dedicate additional time to dig...
Hi @mmarczell-graphisoft I am sorry but your reproduction seems quite complex to me with lots of moving parts and to be honest I cannot even tell what the difference is...
@mmarczell-graphisoft I see, yeah I can totally see the issue now :slightly_smiling_face: (don't worry for leaving that out, it happens :smiley:) Thanks for the explanation :slightly_smiling_face: ___ (by the way,...
Hi @mmarczell-graphisoft I'm so sorry for the late reply :bow: ___ First of all I would suggest to ignore the `ShadowDom` workaround, as that doesn't seem to be very compatible...
Hi @mmarczell-graphisoft, no problem it was my pleasure, I hope I could have helped some :slightly_smiling_face: I am sorry you had those issues, it must have been a bit painful...
Thanks for tagging me @pkozlowski-opensource :slightly_smiling_face: @dionatan-g sorry, I do not believe this is a false positive, let me explain why, the fact is that your code is actually trying...
@lukasmatta yeah I was going to say the same :slightly_smiling_face: it is a shame that the first `*ngIf`'s expression always evaluates truthy and we need a second `*ngIf` :sweat: (as...