Dario Piotrowicz

Results 340 comments of Dario Piotrowicz

Hi @abergquist I've created a PR for this I hope you don't mind :slightly_smiling_face: However I think that the right solution here is to use `text-top` instead of completely remove...

by the way, also the removal of the vertical alignment can really create a big difference in other tables, for example here: ![Screenshot at 2022-09-15 22-50-21](https://user-images.githubusercontent.com/61631103/190515322-fbc32519-e15f-4c61-89da-7a15d25529ab.png) versus: ![Screenshot at 2022-09-15...

Hi there :slightly_smiling_face: , I'm just trying to do this small bug fix, I hope my change makes sense :slightly_smiling_face: Anyways the type of the request is still `Request |...

Also I couldn't fine unit tests regarding this `fetch` patching (that's why I didn't add any), is it not being tested? or am I just missing the tests?

> Thanks for putting this together @dario-piotrowicz. From looking at the MDN docs for `fetch()`, it says: > > > The fetch() method's parameters are identical to those of the...

I see, thanks @petebacondarwin and @mrbbot :slightly_smiling_face: , shall I then proceed and create an issue in https://github.com/cloudflare/workers-types?

> Yes please! Done :slightly_smiling_face: https://github.com/cloudflare/workers-types/issues/277

Hi @manucorporat , the variable is being referenced before it's declaration/initialization, but it is not being used right away (so it's not in the temporal dead zone) so I would...

I see, that's too bad 😢 Thank you very much for the explanation 🙂 Let me know if we should just close this issue, keep it for reference or also...

Yeah this is quite a common scenario, having a built-in way to handle it would be nice :slightly_smiling_face: But regarding the proposed solution I am curious, would the `await` pipe...