Lion - dapplion

- PR https://github.com/ChainSafe/lodestar/pull/4493 filled executionOptimistic in all methods that required it, but the implementation is missing for some Compute correct executionOptimistic flag for all remaining API routes

StateArchiver use epoch as key instead of slot

1

**Describe the bug** In StateArchiver logic to prune states, epoch is used a key to index and prune states, which are actually indexed by slot https://github.com/ChainSafe/lodestar/blob/db9450ba2ee4ac90469999450a16d143f6127961/packages/beacon-node/src/chain/archiver/archiveStates.ts#L48-L52 Current parameters in to...

Potential slow memory leak seen in Ropsten nodes

2

**Describe the bug** Of about 42MB/day, seen in Ropsten nodes in the last 14 days. They run unstable without watchtower so don't update automatically. Versions run through this period: -...

Invalid schema in GetPeersResponse

1

The response schema for GetPeersResponse is invalid according to [AJV](https://ajv.js.org) ``` Error: "nullable" cannot be used without "type" at getSchemaTypes (node_modules/ajv/lib/compile/validate/dataType.ts:26:13) at typeAndKeywords (node_modules/ajv/lib/compile/validate/index.ts:159:31) at subSchemaObjCode (node_modules/ajv/lib/compile/validate/index.ts:147:3) at subschemaCode (node_modules/ajv/lib/compile/validate/index.ts:124:7)...

Reason of allOf usage?

4

Some properties are defined with allOf notation https://github.com/ethereum/beacon-APIs/blob/9cab46ad3c94a4a2779b42fa21f6bb1955b60b56/types/primitive.yaml#L40-L44 instead of just ```yaml ExecutionOptimistic: type: boolean example: false description: "True if the response references an unverified execution payload. Optimistic information may...

Benchmarks to understand the cost of extra iterations in AsyncIterable flows Benchmark output in a 4 core, model name: Intel(R) Core(TM) i5-8250U CPU @ 1.60GHz ``` abortableSource cost ✔ async...

Use libs native timeout features instead of a custom solution

1

Proper change to fix a necessity for the aragonCLI refactor. I would advise using this solution over https://github.com/aragon/apm.js/pull/43. **However** for the lack of tests in this library the affected functions...

Tree retains memory in global? scope - causes OOM :warning:

1

This gist demostrates a case where memory is retained in some upper scope such that it's not garbage collected. https://gist.github.com/dapplion/e079d8faf795f758f1f3b341ee590dc2 ```ts import {ssz} from "@chainsafe/lodestar-types"; let i = 0; const...

Nimbus uses a very nice optimization that we should implement too: When serializing state, don't serialize + deserialize Validator object fields `withdrawal_credentials` and `pubkey`. Instead store this data is a...

NodeJS represents Uint8Arrays inefficiently when they have small sizes. The validators object have pubkey and withdrawal_credentials that can be thought as an append-only list which take ~140MB in a single...