apm.js icon indicating copy to clipboard operation
apm.js copied to clipboard

Use libs native timeout features instead of a custom solution

Open dapplion opened this issue 5 years ago • 1 comments

Proper change to fix a necessity for the aragonCLI refactor. I would advise using this solution over https://github.com/aragon/apm.js/pull/43. However for the lack of tests in this library the affected functions should be tested manually in different environments to ensure stability.

The current setTimeout usage was causing a leak that prevented Node.js processes to finalize, keeping the event loop alive for 5 more minutes than necessary.

dapplion avatar Dec 05 '19 11:12 dapplion

Thanks, will look at it over the weekend and manually test it with a few dependant packages 👍

0xGabi avatar Dec 05 '19 20:12 0xGabi