Lion - dapplion

getEffectiveBalanceIncrementsZeroInactive mutates cache

1

**Describe the bug** Function `getEffectiveBalanceIncrementsZeroInactive` says https://github.com/ChainSafe/lodestar/blob/0de01443f1f4cfa6efc12783c5783f0035e4e29f/packages/state-transition/src/util/balance.ts#L57-L58 But immediately after mutates the balances setting them to zero https://github.com/ChainSafe/lodestar/blob/0de01443f1f4cfa6efc12783c5783f0035e4e29f/packages/state-transition/src/util/balance.ts#L66-L67 So the .slice() **MUST** copy the array as it will be mutated...

Reduce one pipe level in ReqResp handler

1

**Motivation** - Spin-off from https://github.com/ChainSafe/lodestar/pull/4345 with a useful change **Description** - Reduce one pipe level in ReqResp handler - Move timeout test to main ReqResp handler function

Move archive logic to BeaconChain class

1

**Motivation** Having archive logic far away from BeaconChain class has the negative side-effect of complicating logic and making it harder to provide flow control guarantees that don't break prunning. The...

Move produceBlock main function to BeaconChain class

1

**Motivation** - Very similar motivation to https://github.com/ChainSafe/lodestar/pull/4379 The current code organization of this files is extremely old (from almost 3y ago), and requires many dependencies of BeaconChain to be made...

**Motivation** General clean-up, drop the need to have an intermediary event and re-use code from findAttesterDependentRoot **Description** - Generalize `findAttesterDependentRoot` to support previous epoch and current epoch - Use getDependantRoot...

**Describe the bug** In `maybeArchiveState` function epoch is used a key instead of slot. This probably means that Lodestar is not pruning states are expected having a larger db than...

**Motivation** RootCache may become unnecessary after merging SSZ v2. - From https://github.com/ChainSafe/lodestar/issues/3998 - See https://github.com/ChainSafe/lodestar/pull/4374 for a performance test Marking as draft to decide first if this is a good...

RootCache is an optimization that prevent having to walk the tree repeatedly when processing attestations. After merging https://github.com/ChainSafe/lodestar/pull/3760 the optimization may not be necessary anymore: - [ ] Add performance...

Peer ID doesn't match libp2p public key

1

**Describe the bug** Running in denver gnosis testnet, Lodestar is unable to discover peers because all discovered peers throw ``` Aug-01 23:17:38.392[NETWORK] debug: Error dialing discovered peer peer=16...zfqTuk Error: Error...

Unknown block sync peerId conversion issue

2

In Sepolia, seems an error of conversion ``` Jul-06 14:24:35.555[SYNC] error: Downloaded block parent is before finalized slot finalizedSlot=115200, parentSlot=115192, parentRoot=0xd1670e16e8614871ea41daddd96aeab17f55b0a331afb5577e99100a7a83c1db Jul-06 14:24:35.559[SYNC] error: Removing unknown parent block root=0x1815dbd1a77bf2530893ef2c9bf6250a84be6b913cfe76d164d5f9c716d8728d, slot=115208...