Dan Bailey
Dan Bailey
I don't believe there to be any more feedback needing addressed for this PR. @Idclip - if you're happy can you approve please?
> I don't believe there to be any more feedback needing addressed for this PR. @Idclip - if you're happy can you approve please? @Idclip - can you have a...
Looks good. My main request is to add support for on-the-fly converting of Houdini points to VDB points and then rename this VDB Surfacer, then I'd be good for this...
> > Looks good. My main request is to add support for on-the-fly converting of Houdini points to VDB points and then rename this VDB Surfacer, then I'd be good...

> Thank you for providing this. Hopefully these comments make sense! Great feedback, exactly what I was after, thank you! I'll work on updating with a revised version...
> In particular, I'd be curious if people have profiled the destruction of enormous trees. I see that `~Tree()` calls `Tree::clear()` which calls `stealNodes` in serial then > > ```...
@idclip Actually I introduced `OPENVDB_TEMPLATE_IMPORT` and `OPENVDB_TEMPLATE_EXPORT` as the rules are slightly different to `OPENVDB_API` on Windows in particular. However, these should be defined automatically: https://github.com/AcademySoftwareFoundation/openvdb/blob/master/openvdb/openvdb/util/ExplicitInstantiation.h#L11 I wasn't aware that...
> @danrbailey What I am understanding after reading the issue and code is that if we get the older version, we need to disable compression. So do we need to...
> Can I give this issue a try? Yes, by all means. :)