openvdb icon indicating copy to clipboard operation
openvdb copied to clipboard

Dummy Point Surfacing SOP for testing purposes

Open Idclip opened this issue 2 years ago • 4 comments

Signed-off-by: Nick Avramoussis [email protected]

@jmlait I haven't tried to use this SOP since the initial PR which was a while ago - it still builds and looks okay but let me know if you have any issues

Idclip avatar May 24 '22 21:05 Idclip

I spoke too soon, it doesn't build... I'll fix these soon

Idclip avatar May 24 '22 21:05 Idclip

Looks good. My main request is to add support for on-the-fly converting of Houdini points to VDB points and then rename this VDB Surfacer, then I'd be good for this to be merged more or less as-is. There are a few other small things - renaming the methods to make them a bit more descriptive (rasterZbP), removing the redundant inline statement on the templated methods, tidying up some the parameters and tooltips and ideally making this a compiled SOP instead of using duplicateSourceStealable().

This can be done as a later change after this has been merged, but it would also be good to support rasterizing multiple VDB points grids into a single level set and to add streaming support.

danrbailey avatar Jun 04 '22 21:06 danrbailey

Looks good. My main request is to add support for on-the-fly converting of Houdini points to VDB points and then rename this VDB Surfacer, then I'd be good for this to be merged more or less as-is. There are a few other small things - renaming the methods to make them a bit more descriptive (rasterZbP), removing the redundant inline statement on the templated methods, tidying up some the parameters and tooltips and ideally making this a compiled SOP instead of using duplicateSourceStealable().

This can be done as a later change after this has been merged, but it would also be good to support rasterizing multiple VDB points grids into a single level set and to add streaming support.

Thanks for the feedback - I agree with everything you've said but this was never designed to be a feature ready SOP, only to provide the necessary hooks in Houdini so people could test. If you think this is actually worth making feature complete (i.e. native SideFX support) then I'd want to go back and re-write this/re-work the UI entirely - but I'm also not sure that's worth doing until we've figured out how best to expose all these raster tools in Houdini?

Idclip avatar Jun 10 '22 12:06 Idclip

Looks good. My main request is to add support for on-the-fly converting of Houdini points to VDB points and then rename this VDB Surfacer, then I'd be good for this to be merged more or less as-is. There are a few other small things - renaming the methods to make them a bit more descriptive (rasterZbP), removing the redundant inline statement on the templated methods, tidying up some the parameters and tooltips and ideally making this a compiled SOP instead of using duplicateSourceStealable(). This can be done as a later change after this has been merged, but it would also be good to support rasterizing multiple VDB points grids into a single level set and to add streaming support.

Thanks for the feedback - I agree with everything you've said but this was never designed to be a feature ready SOP, only to provide the necessary hooks in Houdini so people could test. If you think this is actually worth making feature complete (i.e. native SideFX support) then I'd want to go back and re-write this/re-work the UI entirely - but I'm also not sure that's worth doing until we've figured out how best to expose all these raster tools in Houdini?

I think it absolutely could be a feature-ready SOP, there's a real gap in our toolset for a SOP like this. I think to make progress here and side-step the issue of rasterization, it would be worth introducing a Surfacing SOP like this that has a narrower scope and specializes in turning points into an SDF and not also rasterizing arbitrary attributes or generating fog volumes or masks. As I see it, it's an open source equivalent to the VDB from Particle Fluid SOP (which I believe also does not do arbitrary attribute rasterization) and it's through this node that we can introduce any other surfacing algorithms like anisotropic surfacing. After all, there's still the VDB from Particles SOP which has broader scope, like doing arbitrary attribute rasterization.

danrbailey avatar Jun 10 '22 18:06 danrbailey