Daniel Xu
Daniel Xu
Yeah, agreed. Unfortunately I haven't had any good ideas about how to present that yet.
I wrote down some ideas in https://github.com/danobi/prr/pull/47#issuecomment-1878953383 Still pondering some things, but expecting to start writing code for it soon
Yeah, per commit reviewing would be nice. Although I believe even GH itself has restrictions on what kind of comments you can leave on per-commit reviews. IIRC you can't do...
I am also thinking about this in the context of https://github.com/danobi/prr/pull/47#issuecomment-1878953383 . I believe we can build on top of PR metadata for this
Thanks for the pointers!
When I try leaving a comment on the 0 line I get this error: ``` Error: Error during POST: Status code: 422 Unprocessable Entity, Body: {"message":"Unprocessable Entity","errors":["Pull request review thread...
> are there plans to implement support for GitLab as well? I have no plans to support it. But I would probably take a PR for it if gitlab support...
It wasn't necessarily intentional (as in I don't have anything against windows). Just that I don't use it and don't have any windows computers. If you'd like to send a...
Error checking would be good. Do you have a reproducer I can test with?
Sure. Try my email in the git log.